Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ danjoa
❌ dimaanj
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

Last corrections since the last session

• jest timeout changed from 5000 to 10000 to support new chinook test
• revised folder layout → putting all frontend-related things under ./app. Adjusted webpack config for that
• renamed media-store to chinook.
• tests → to be included in our regular tests. tests moved to /test folder
• app/html5Deployer/resources should be cleaned up each build. It is not really webpack task to clean folder besides js build. Webpack prevents doing things outside root src. More applicable will be clean it somehow by bash/cmd automated scripts
• added mocked secret strings to mta.yaml the same as in .env for dev

Suppose someone should do this later:

• rename bookshop to books and fiori to bookstore. Because it leads to problems with test runner. Suppose package.json and other things should be changed at one time with renaming folders
• exclude app/front from cds watcher. See my suggestion here

Needs update

• add chinook to top-level ./samples.md
• review models
• review code
• double-check auth.js
• launching w/ cds watch as usual including react frontend
• double-check corsMiddleware
• deploy(ed) to CF